Hacksaw Ridge is really good of the modern ones. As is Anthropoid and Inglorius Basterds. Valkyrie too I liked.
Admittedly and shamefully I've not seen a load of the classics. Good morning Vietnam and Schindler's list are two that I did enjoy though.