I'll dissect some of your post point by point...
Whilst Charles was in the military we did not have any major conflicts. Pretty difficult to go to war when there isn't one to go to.
The Royal Yacht is no longer in active service. Also, please bear this in mind ref your comment about the cost...
Indeed the Overseas Trade Board estimates that £3 billion has been made for the Exchequer as a result of commercial days on Britannia between 1991 and 1995.
The 'Royal Flight' does not exist as such any longer. It is now 32 Squadron & is only used for VIP duties when not required on military duties. Indeed, the MOD has stated...
the principal purpose of 32 Squadron [is] to provide communications and logistical support to military operations; the Squadron's capacity should be based on military needs only; and any royal or other non-military use of... spare capacity is secondary to its military purpose.
Harry
has served in the Gulf. This despite the fact that he could have easily avoided doing so due to his Royal status.
William
has chosen to undertake a full time military career. This despite the fact that he could have avoided, etc, etc
Now... what fucking planet are
you on?